Add option to horizontally homogenize the Stokes drift when used via … #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
added
enhancement
Hallberg-NOAA
approved these changes
Sep 9, 2025
added 2 commits
September 9, 2025 13:27
…the dataoverride surfbands procedure.
Hallberg-NOAA
force-pushed
the
Homogenize_Surfbands
branch
from
8da6b55 to
53e2942
Compare
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/28779. There, however, is no report of the MOM_parameter_doc files changing due to the new runtime parameter, perhaps suggesting that this new capability is not in code that is being exercised by the pipeline testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the dataoverride surfbands procedure.
I'm not sure why, but there can be round-off differences in Stokes drift from the current data-override procedure in the Stokes drift. These round-off differences across columns that were meant to be identical eventually propagate enough to cause the single column model implementation to be unstable and to fail. It is similar to why we needed the ability to homogenize the horizontal forcing for using data-override surface forcing in single column mode. The same algorithm was followed here.